The following guidelines apply to all code of the Eclipse SmartHome project. They must be followed to ensure a consistent code base for easy readability and maintainability. Exceptions can certainly be made, but they should be discussed and approved by a project committer upfront.
Note that this list also serves as a checklist for code reviews on pull requests. To speed up the contribution process, we therefore advice to go through this checklist yourself before creating a pull request.
A. Code Style
- The Java naming conventions should be used.
- Every Java file must have a license header. You can run
mvn license:formaton the root of the repo to automatically add missing headers.
- Every class, interface and enumeration should have JavaDoc describing its purpose and usage.
- Every class, interface and enumeration must have an @author tag in its JavaDoc for every author that wrote a substantial part of the file.
- Every constant, field and method with default, protected or public visibility should have JavaDoc (optional, but encouraged for private visibility as well).
- Code must be formatted using the provided code formatter and clean up settings. They are set up automatically by the official IDE setup.
- Generics must be used where applicable.
- Code should not show any warnings. Warnings that cannot be circumvented should be suppressed by using the @SuppressWarnings annotation.
- For dependency injection, OSGi Declarative Services should be used.
- OSGi Declarative Services should be declared using annotations. The IDE will take care of the service *.xml file creation. See the official OSGi documentation for an example here.
- Packages that contain classes that are not meant to be used by other bundles should have “internal” in their package name.
- We are using null annotations from the Eclipse JDT project. Therefore every bundle should have an optional
org.eclipse.jdt.annotation. Classes should be annotated by
@NonNullByDefaultand return types, parameter types, generic types etc. are annotated with
@Nullableonly. There is no need for a
@NonNullannotation because it is set as default. The transition of existing classes could be a longer process but if you want to use nullness annotation in a class / interface you need to set the default for the whole class and annotate all types that differ from the default. Test classes do not have to be annotated.
B. OSGi Bundles
- Every bundle must contain a Maven pom.xml with a version and artifact name that is in sync with the manifest entry. The pom.xml must reference the correct parent pom (which is usually in the parent folder).
- Every bundle must contain an about.html file, providing license information.
- Every bundle must contain a build.properties file, which lists all resources that should end up in the binary under
- The manifest must not contain any “Require-Bundle” entries (except for test fragment bundles, see below). Instead, “Import-Package” must be used.
- The manifest must not export any internal package.
- The manifest must not have any version constraint on package imports, unless this is thoughtfully added. Note that Eclipse automatically adds these constraints based on the version in the target platform, which might be too high in many cases.
- The manifest must include all services in the Service-Component entry. A good approach is to put OSGI-INF/*.xml in there.
- Every exported package of a bundle must be imported by the bundle itself again.
- Test fragments may have the bundles
org.mockitoin the “Require-Bundle” section. This is the only exception to not having “Require-Bundle” at all.
C. Language Levels and Libraries
- Eclipse SmartHome generally targets JavaSE 8 with the following restrictions:
- To allow optimized JavaSE 8 runtimes, the set of Java packages to be used is furthermore restricted to Compact Profile 2
- Java 5 for org.eclipse.smarthome.protocols.enocean.*
- The minimum OSGi framework version supported is OSGi R4.2, no newer features must be used.
- For logging, slf4j (v1.7.2) is used.
- A few common utility libraries are available that every Eclipse SmartHome based solution has to provide and which can be used throughout the code (and which are made available in the target platform):
- Apache Commons IO (v2.2)
- Apache Commons Lang (v2.6)
- Google Guava (v10.0.1)
D. Runtime Behavior
- Overridden methods from abstract classes or interfaces are expected to return fast unless otherwise stated in their JavaDoc. Expensive operations should therefore rather be scheduled as a job.
- Creation of threads must be avoided. Instead, resort into using existing schedulers which use pre-configured thread pools. If there is no suitable scheduler available, start a discussion in the forum about it rather than creating a thread by yourself. For periodically executed jobs that do not require a fixed rate scheduleWithFixedDelay should be preferred over scheduleAtFixedRate.
- Bundles need to cleanly start and stop without throwing exceptions or malfunctioning. This can be tested by manually starting and stopping the bundle from the console (
- Bundles must not require any substantial CPU time. Test this e.g. using “top” or VisualVM and compare CPU utilization with your bundle stopped vs. started.
- As we are in a dynamic OSGi environment, loggers should be non-static, when ever possible and have the name
- Parametrized logging must be used (instead of string concatenation).
- Where ever unchecked exceptions are caught and logged, the exception should be added as a last parameter to the logging. For checked exceptions, this is normally not recommended, unless it can be considered an error situation and the stacktrace would hold additional important information for the analysis.
- Logging levels should focus on the system itself and describe its state. As every bundle is only one out of many, logging should be done very scarce. It should be up to the user to increase the logging level for specific bundles, packages or classes if necessary. This means in detail:
- Most logging should be done in
tracecan be used for even more details, where necessary.
- Only few important things should be logged in
infolevel, e.g. a newly started component or a user file that has been loaded.
warnlogging should only be used to inform the user that something seems to be wrong in his overall setup, but the system can nonetheless function as normal, while possibly ignoring some faulty configuration/situation. It can also be used in situations, where a code section is reached, which is not expected by the implementation under normal circumstances (while being able to automatically recover from it).
errorlogging should only be used to inform the user that something is tremendously wrong in his setup, the system cannot function normally anymore, and there is a need for immediate action. It should also be used if some code fails irrecoverably and the user should report it as a severe bug.
- Most logging should be done in
- For bindings, you should NOT log errors, if e.g. connections are dropped - this is considered to be an external problem and from a system perspective to be a normal and expected situation. The correct way to inform users about such events is to update the Thing status accordingly. Note that all events (including Thing status events) are anyhow already logged.
- Likewise, bundles that accept external requests (such as servlets) must not log errors or warnings if incoming requests are incorrect. Instead, appropriate error responses should be returned to the caller.
Static code analysis
The Eclipse SmartHome Maven build includes tooling for static code analysis that will validate your code against the Coding Guidelines and some additional best practices. Information about the checks can be found here.
The tool will generate an individual report for each bundle that you can find in
path/to/bundle/target/code-analysis/report.html file and a report for the whole build that contains links to the individual reports in the
target/summary_report.html. The tool categorizes the found issues by priority: 1(error),2(warning) or 3(info). If any error is found within your code the Maven build will end with failure. You will receive detailed information (path to the file, line and message) listing all problems with Priority 1 on the console.
Please fix all the Priority 1 issues and all issues with Priority 2 and 3 that are relevant (if you have any doubt don’t hesitate to ask). Re-run the build to confirm that the checks are passing.